Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI for MinGW #190

Open
MBkkt opened this issue Aug 7, 2022 · 1 comment
Open

Fix CI for MinGW #190

MBkkt opened this issue Aug 7, 2022 · 1 comment
Labels
bug Something isn't working devops DevOps tasks good first issue Good for newcomers
Milestone
Not main priority

Comments

@MBkkt
Copy link
Member

MBkkt commented Aug 7, 2022 •
edited

First of feel free to ask me(@MBkkt) any questions about this task, often the task may not be described in enough detail for devs who don't have the full context.

Describe the bug
We promise that YACLib works correctly with MinGW and it worked the last time I tried it.
We used to have MinGW in our CI.
But the MinGW installation provided by https://github.com/egor-tensin/setup-mingw was very unstable.
Therefore, we decided to temporarily disable it.

I think we can try to use https://github.com/msys2/setup-msys2

Expected behavior
Reliable MinGW tests in our CI
@MBkkt MBkkt added bug Something isn't working good first issue Good for newcomers devops DevOps tasks labels Aug 7, 2022
@MBkkt MBkkt added this to the Not main priority milestone Aug 7, 2022
@MBkkt
Copy link
Member Author

MBkkt commented Nov 25, 2022

https://github.com/simdjson/simdjson/blob/master/.github/workflows/msys2.yml yep it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working devops DevOps tasks good first issue Good for newcomers
Projects
None yet
Milestone
Not main priority
Development

No branches or pull requests
1 participant
@MBkkt