Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pad random graphs with 0s so they are in the right order #129

Open
KirstieJane opened this issue Jul 5, 2019 · 4 comments
Open

Pad random graphs with 0s so they are in the right order #129

KirstieJane opened this issue Jul 5, 2019 · 4 comments

Comments

@KirstieJane
Copy link
Member

image

It doesn't make sense to report the random graphs in this order, and I think it could cause some confusions in certain use cases.

I think we should pad the random graphs with 0s so they're numbered:

  • R0000
  • R0001
  • R0002
  • R0003

etc

I'm happy to take suggestions for the number of 0s to pad with. 10,000 random graphs would need 5 characters: R00001 ---> R10000, which seems pretty sensible to me.

What do you think?

@wingedRuslan
Copy link
Collaborator

wingedRuslan commented Jul 5, 2019

well, if it could possibly cause some confusions in certain use cases, we should make changes to the order by renaming random graphs

Do you suggest instead of "Real_Graph_R0" --> "Real_Graph_R1000" to have "R0000" --> "R1000" for 1000 random graphs?

@KirstieJane
Copy link
Member Author

Yes - exactly 👍

@wingedRuslan
Copy link
Collaborator

How should the number of digits be allocated?

if we create 1000 random graphs -> then 4 digits, 10 000 -> 5 digits?

@Islast
Copy link
Collaborator

Islast commented Jul 25, 2019

It seems like the problem here might be that the graphbundle is inherently unordered (its base type is a dict). Following the work we did on permuting groups, it's beginning to seem like the dict class is not ideal for graph bundle.

@Islast Islast mentioned this issue Dec 13, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants