Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register HTTP checks #216

Open
bustikiller opened this issue May 21, 2021 · 3 comments
Open

Register HTTP checks #216

bustikiller opened this issue May 21, 2021 · 3 comments

Comments

@bustikiller
Copy link

Why

Consul supports the configuration of multiple types of checks to verify that services are up and running. In the documentation of Diplomat::Check I see that #register_script and #register_ttl are implemented, while registration for other check kinds is missing.

What

Extend Diplomat::Check to support the registration of HTTP + Interval checks.

@pierresouchay
Copy link
Member

@bustikiller Indeed, this is missing.
Would you like to propose a PR? I'll review it quickly.

Regards

@bustikiller
Copy link
Author

@bustikiller Indeed, this is missing.
Would you like to propose a PR? I'll review it quickly.

Regards

I would love to, I will try to find some time to prepare a PR and send it over to you.

Thanks!

@bustikiller
Copy link
Author

@pierresouchay I am afraid I won't be able to take care of this development, sorry for the late reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants