Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashmaps: rearrange overwriting instructions #27999

Merged
merged 1 commit into from
May 20, 2024

Conversation

gingkapls
Copy link
Contributor

Because

The order of instructions in the hashmap lesson may lead to confusion over the process of overwriting values if the key already exists in the map.

This PR

  • Rearranges the instructions on overwriting values so that confusion is removed and the lesson flows better.
  • Removes unnecessary bullet about adding a Node as it's irrelevant to the process of retrieving a value from the map

Issue

Closes #27982

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

this commit changes the order of the instructions to overwrite values, so that they appear just after insertion into the hashmap is talked about
@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label May 18, 2024
@CouchofTomato
Copy link
Member

@JoshDevHub Just wanted to check this matched your view on the change?

Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Thank you for contributing.

@JoshDevHub JoshDevHub merged commit ca7fca8 into TheOdinProject:main May 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HashMap Data Structure: Paragraph about overwriting values seems misplaced
3 participants