You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The classmethod Segment._split_cells uses a heuristic to start the search for the cut point that is too eager.
Because the algorithm implemented doesn't backtrack, one can construct example strings for which the cuts have the wrong sizes.
The two examples below show instances of the wrong result being computed.
We replace the linear search with a binary search like the one in cells.py::set_sell_size.
This doesn't seem to produce a significant impact in the performance of the method but it does fix bug #3299.
The classmethod
Segment._split_cells
uses a heuristic to start the search for the cut point that is too eager.Because the algorithm implemented doesn't backtrack, one can construct example strings for which the cuts have the wrong sizes.
The two examples below show instances of the wrong result being computed.
The text was updated successfully, but these errors were encountered: