Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Optimize the user experience of the create #5370

Open
CC11001100 opened this issue Feb 1, 2023 · 9 comments
Open

[Feature] Optimize the user experience of the create #5370

CC11001100 opened this issue Feb 1, 2023 · 9 comments

Comments

@CC11001100
Copy link

Maybe we can skip the selection process when the organization name of the github repository is the same as the repository name?

image

image

@CC11001100
Copy link
Author

function choose_item($list, $query) {

@CC11001100
Copy link
Author

Or at least do a distinct

@HUMORCE
Copy link
Member

HUMORCE commented Feb 1, 2023

The <url> in this command refers to the download url.

btw, scoop-create is an outdated, unmaintained command.

Manifest template:
https://github.com/ScoopInstaller/BucketTemplate/blob/master/bucket/app-name.json.template

❯ scoop create https://github.com/selefra/selefra/releases/download/v0.0.8/selefra_windows_amd64.zip
1) selefra
2) selefra
3) releases
4) download
5) v0.0.8
6) selefra_windows_amd64.zip
App name: 1
1) selefra
2) selefra
3) releases
4) download
5) v0.0.8
6) selefra_windows_amd64.zip
Version: 5
Created 'C:\Users\humorce\selefra.json'.

❯ cat C:\Users\humorce\selefra.json
{
  "hash": "",
  "depends": "",
  "bin": "",
  "url": "https://github.com/selefra/selefra/releases/download/v0.0.8/selefra_windows_amd64.zip",
  "license": "",
  "extract_dir": "",
  "homepage": "",
  "version": "v0.0.8"
}

@CC11001100
Copy link
Author

image

Sorry, I misunderstood the meaning of the command, I thought the url was the home page of the project to be created, but did not think it was the download path of the installation package, maybe this prompt should be modified? For example, change to:

PS D:\workspace\selefra> scoop create --help
Usage: scoop create <download-url>

Create your own custom app manifest

Thank you for answering my question

@HUMORCE
Copy link
Member

HUMORCE commented Feb 1, 2023

emmm, I did not use this command before. it needs to be refactored, or deprecated.

It is recommended to create new manifests based on template or a similar manifest.

@amreus
Copy link

amreus commented Feb 19, 2023

Coincidentally, I was thinking of this command today. As it is, create is very basic but it can be improved. In the case of a Github download there is no reason create could not create a complete manifest including 32 and 64 bit versions, latest versions, and hash values. All the information is available on Github and usually at a predictable path. As is typical, "all" that is needed is someone to do it.

@CC11001100
Copy link
Author

I can do it, But if I do, will it be merge? Will it help other people ?

Coincidentally, I was thinking of this command today. As it is, create is very basic but it can be improved. In the case of a Github download there is no reason create could not create a complete manifest including 32 and 64 bit versions, latest versions, and hash values. All the information is available on Github and usually at a predictable path. As is typical, "all" that is needed is someone to do it.

@rashil2000
Copy link
Member

Yes, please make a PR!

@CC11001100
Copy link
Author

cool, I'll try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants