You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently disable readability-else-after-return which is a wonderful check that finds easy ways to improve readability, reduce indentation, and reduce line count. It's an all around win to enforce this check and transform SFML to adhere to it. Lots of new code written already adheres to style since the benefits of guard clauses are well established.
clang-tidy offers an automatically fixer for this check so actually writing the PR will be as easy as letting clang-tidy rewrite the codebase.
The text was updated successfully, but these errors were encountered:
@vittorioromeo and I have discussed this in past PRs and we both prefer this style. I'm happy to write the commit in case we want to look at how the code actually changes. That may help us understand this check and what exactly it will change about SFML.
Here's most of what this change will look like. This only took a few minutes of running clang-tidy locally to get this far. If we agree on this I won't rebase this branch but rather just do it all again on the current state of master.
https://clang.llvm.org/extra/clang-tidy/checks/readability/else-after-return.html
We currently disable
readability-else-after-return
which is a wonderful check that finds easy ways to improve readability, reduce indentation, and reduce line count. It's an all around win to enforce this check and transform SFML to adhere to it. Lots of new code written already adheres to style since the benefits of guard clauses are well established.clang-tidy offers an automatically fixer for this check so actually writing the PR will be as easy as letting clang-tidy rewrite the codebase.
The text was updated successfully, but these errors were encountered: