Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives for check Message Easy To Find #588

Open
NilsABCD opened this issue Mar 10, 2023 · 1 comment
Open

False positives for check Message Easy To Find #588

NilsABCD opened this issue Mar 10, 2023 · 1 comment
Labels
bug Something isn't working correctly

Comments

@NilsABCD
Copy link

NilsABCD commented Mar 10, 2023

Check Name
Message Easy To Find

Issue
The check produces a high number of false positives. Here are some examples where this can be observed:

  1. The check does also report findings for messages in text pools which makes no sense. Example code:

    data lv_etext type c length 100.
    lv_etext = 'No authority to replay'(e12).
    message lv_etext type 'I'.

  2. The check reports findings for messages that are thrown without the use of a message class (at least when you add a RAISING to the statement). Example code:

    data l_text type string.
    l_text = 'success'.
    message l_text type 'I' raising a.

  3. Even when the message class and message number are correctly defined with literals, the check raises a finding as soon as the addition 'WITH' or 'RAISING' or both of them are used. Example Code:

    message id '/AIF/BDC' type 'E' number '013' with iv_typename raising a.

I also found many cases where the statement was completely fine and the check still reported a finding, but I wasn't able to see a pattern when this happens and when not.

@NilsABCD NilsABCD added the bug Something isn't working correctly label Mar 10, 2023
@StefanButscher
Copy link

I found have similar issue.

MESSAGE ID '/CIF/ENH_DPP' TYPE default_severity NUMBER 002 INTO DATA(message).

Raises and message easy to find, yet I can directly get it via where used from se91.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

2 participants