Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The article content section disappears on launch. #4030

Open
GetToSet opened this issue Jun 12, 2023 · 5 comments · May be fixed by #4032
Open

The article content section disappears on launch. #4030

GetToSet opened this issue Jun 12, 2023 · 5 comments · May be fixed by #4032

Comments

@GetToSet
Copy link
Contributor

Screenshot 2023-06-12 13 08 56

NetNewsWire: Version 6.1.2 (6114)
macOS: 13.5 Beta (22G5038d)
Safari: 16.6 (18615.3.5.11.2)

This is an issue I encounter myself with the latest stable release of NetNewsWire. I'll see if more detail could be added here.

@GetToSet
Copy link
Contributor Author

We got the WKWebView here, but interestingly it remains transparent and shows up nothing.
Screenshot 2023-06-12 13 29 28

@stuartbreckenridge
Copy link
Member

Is it possible this is a 13.5 beta issue?

@GetToSet
Copy link
Contributor Author

Is it possible this is a 13.5 beta issue?

Likely, but I could not get to the conclusion now.

We intentionally hide the WKWebView on launch and unhide it on webView:didFinishNavigation: delegate callback to prevent the initial flash on dark mode.

It took significantly longer time for a hidden webView to reach this delegate call. For most articles, this takes about 0.5-1 second, which should already been considered abnormal. For certain articles, it surprisingly takes 30 seconds or more.

output.mp4

A non-hidden webView seems to work fine.

I'll see if this could be reproduced with my other Macs (have to be upgraded first, though).

@vincode-io
Copy link
Member

I had forgotten that we did this trick on the Mac. We might want to change this to work the same way that I recently did for iOS.

@GetToSet
Copy link
Contributor Author

This issue is not related with the beta OS. It's caused due to WKWebView sends webView:didFinishNavigation: when all resources are loaded, which waits until all images to be loaded (or times out, for my case).

It should be easy to reproduced with Network Link Conditioner.

Simply changing didFinishNavigation: to didCommitNavigation: would be sufficient to fix this issue while preserving the flashing fix for dark mode. I'll raise a pull request after testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants