Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q. Cleaning R code #13

Open
orchid00 opened this issue Sep 21, 2018 · 5 comments
Open

Q. Cleaning R code #13

orchid00 opened this issue Sep 21, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@orchid00
Copy link
Contributor

Would you be happy if I clean your R code?
This raincloud plots are awesome and I'd like to contribute by adding double quotes to all parameter values, for consistency. At the moment some of your parameters have double quotes and some have single quotes. Also I'd like to ident the code after plus signs when adding layers to the plot.

If you give me an OK, I'll be happy to work on that.

@KirstieJane
Copy link
Member

That would be fantastic! Please do!Thank you @orchid00

@orchid00
Copy link
Contributor Author

I've made PR's on the .R files

@orchid00
Copy link
Contributor Author

Tip for Rmd if you want to add
You can save images in a folder with knitr::opts_chunk$set(fig.path = "../figs/")

@KirstieJane
Copy link
Member

Thanks @orchid00! I'm taking a look at #14 #16 #15 now ✨

Unfortunately I'm not a regular R user so I'm wondering if you could link me to the style guide that you're following? I'm curious to know whether they're personal style differences or a standard style that we could follow going forwards 😸

@KirstieJane KirstieJane added the enhancement New feature or request label Sep 26, 2018
@orchid00
Copy link
Contributor Author

I've used the styler package https://github.com/r-lib/styler :) will recommend it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants