Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay announces own IRC join #400

Open
half-duplex opened this issue May 3, 2022 · 3 comments
Open

Relay announces own IRC join #400

half-duplex opened this issue May 3, 2022 · 3 comments
Labels
improvement Improves on something that already exists Telegram Issues relating to Telegram bridge
Milestone

Comments

@half-duplex
Copy link
Contributor

Summary

TeleIRC announces its own IRC join in Telegram.

Standard debugging steps

How to reproduce?

  1. Configure TeleIRC with SHOW_JOIN_MESSAGE=true
  2. Start the relay
  3. Observe that in Telegram the bot has said "* botname joins"

Expected behavior

The relay knows its own IRC nick and does not relay its own join message, since this isn't useful to people on Telegram (or this purpose would probably be better served by a /status command)

@half-duplex half-duplex added bug Something isn't working needs triage Metadata needs to be triaged and updated labels May 3, 2022
@jwflory jwflory added improvement Improves on something that already exists Telegram Issues relating to Telegram bridge and removed bug Something isn't working needs triage Metadata needs to be triaged and updated labels May 10, 2022
@jwflory jwflory added this to Current sprint in TeleIRC development via automation May 10, 2022
@jwflory jwflory added this to the v2.x.x milestone May 10, 2022
@jwflory
Copy link
Member

jwflory commented May 10, 2022

I'm triaging this as an improvement instead of a bug because I think this is actually working as intended. But I get how it can be annoying and doesn't provide much value to people in the Telegram chat, so I think it is worthwhile to keep this open on the backlog.

@jwflory jwflory moved this from Current sprint to Backlog in TeleIRC development May 10, 2022
@half-duplex
Copy link
Contributor Author

After some network issues, here's one place it's potentially useful, announcing the end of outages:

IRC, [22 May 2022 15:32:49]
Lost connection to '#boston2600' on 'cornelius.scuttled.net'

IRC, [22 May 2022 15:40:26]
* r joins

I'm not sure what the best path would be. Maybe make both self-join and connection lost messages configurable? Replace self-joins with "Connected to x"? (Should there be a shutdown message?)

@jwflory
Copy link
Member

jwflory commented Jun 11, 2022

Better verbosity, especially for IRC connectivity, would help. I think replacing self-joins with a "Connected to irc.example.com` is more useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves on something that already exists Telegram Issues relating to Telegram bridge
Projects
Development

No branches or pull requests

3 participants
@half-duplex @jwflory and others