-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Tarantool queue backend #4
Comments
In python abstract classes usually don't serve any good role except for documentation. And they suck as manuals. So the best things we can have here is duck typing, README and tests (to ensure interface compatibility among other things) |
OK, I see. It might be the best moment to use some patterns and other OOP practices but after all duck typing coul be better |
I found an interesting lib that could be the basis for our Tarantool implementation https://github.com/shveenkov/aiotarantool-queue-python . The lib is authored by a Mail.ru dev, it may be a good way to go assuming Tarantool itself is being developed by this company |
Ok, so both of them are merged and both libraries are compatible now |
Seems like it's time to start working on Tarantool queue implementation. I propose the following : a top-level Queue abstract class with general methods (put, get) and RedisQueue and TarantoolQueue classes in corresponding folders. RedisQueue is actually now implemented, making it compatible with abstract parent class would cost nothing
The text was updated successfully, but these errors were encountered: