Align ignoring rules between copy and deletion of files + ignore native module only if they have they vendor/ folder #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quetzacoalt91
changed the title
…ched (= their autoloader is still the one present in the core)
Quetzacoalt91
changed the title
M0rgan01
approved these changes
May 17, 2024
ga-devfront
approved these changes
May 20, 2024
AureRita
approved these changes
May 20, 2024
There was a problem hiding this comment.
Thank you for your PR, I tested it and it seems to works.
Tested on :
1.7.8.11 to 8.1.6
8.0.5 to 8.1.6 ( you corrected this PR : PrestaShop/PrestaShop#36184 )
8.0.5 to 9.0.0 ( you corrected this PR : PrestaShop/PrestaShop#36153 )
8.1.5 to 8.1.16
8.1.5 to 9.0.0
8.1.6 to 9.0.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the way native modules are ignored. If one of them has never been modified (meaning their composer is still the one provided by the core), its content will be upgraded during the process.
ps_googleanalyticsmodule during "Upgrade files" step.* Installation of 8.1.0, deletion and reinstallation of module
ps_googleanalytics, then upgrade to PS 8.1.6 should not delete or copy the module contents during "Upgrade files" step.Error currently found in the CI and fixed by this PR:
This is related to a module
ps_googleanalyticsprovided in both packages 8.1.0 and 8.1.6. In PrestaShop releases, native module dependencies are merged in the core composer.This can be confirmed by checking if a vendor/ folder is present in the module contents:
When installing PrestaShop 8.1.0 and upgrade immediately to 8.1.6, the new core dependencies are copied but:
These 2 issues are respectively fixed by each topic covered in the description.