Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove email "Preview" from BO section "Statutes" (because it's not working) #36165

Open
2 tasks done
ShaiMagal opened this issue May 15, 2024 · 6 comments
Open
2 tasks done
Labels
BO Category: Back Office Bug Type: Bug Email theme Label: Which BO under menu is concerned NMI Status: issue needs more information Order statuses Label: Which BO under menu is concerned Waiting for PM Status: action required, waiting for product feedback

Comments

@ShaiMagal
Copy link
Contributor

ShaiMagal commented May 15, 2024

Prerequisites

Describe the bug and add attachments

Preview button is not working and customers are confused and consistently reporting problem to developers, very difficult to explain it's "security feature", because customers are asking "Why is there button Preview, if it's not working"...

Real issue from real production environment.

1
2

Expected behavior

Preview will show email content only for logged BO users, but it can be a lot of edits, so for now it's better to hide button "Preview" at least. Maybe in future improve it.

Steps to reproduce

  1. Go to BO to section "Statutes"
  2. Open any State with "Send email to customer" enabled
  3. Scroll down and click on button "Preview"
  4. Popup will appears, but we see only error 403 Forbidden (because of security protection of email contents from outside)

PrestaShop version(s) where the bug happened

8.1.5

PHP version(s) where the bug happened

8.1

If your bug is related to a module, specify its name and its version

No response

Your company or customer's name goes here (if applicable).

openservis.cz

@ShaiMagal ShaiMagal added Bug Type: Bug New New issue not yet processed by QA labels May 15, 2024
@florine2623
Copy link
Contributor

Hello @ShaiMagal ,

On develop branch, it works correctly :

Screen.Recording.2024-05-15.at.12.07.14.mov

On PS 8.1.x, I do have a forbidden message.

The feature can be left as is. What do you think @MatShir ?

@florine2623 florine2623 added Waiting for PM Status: action required, waiting for product feedback BO Category: Back Office NMI Status: issue needs more information Order statuses Label: Which BO under menu is concerned Email theme Label: Which BO under menu is concerned and removed New New issue not yet processed by QA labels May 15, 2024
@sharkooon
Copy link

I reported that issue in 2020, still no fix!
#17759

@Hlavtox
Copy link
Contributor

Hlavtox commented May 15, 2024

@ShaiMagal @sharkooon Fixed on develop branch by migration to symfony

@ShaiMagal
Copy link
Contributor Author

I think we can hide it for next 8.1.6 release... Becase every second customer is reporting this problem. It's boring to still "explain" people same think "sorry, it's bug and noone fixed it"...

It makes no sense leave it there if this is not working... Because it looks like bug (in reality this is bug) - so better is to hide it........

Should I make PR for hiding this "non working feature"?

@ShaiMagal
Copy link
Contributor Author

I make PR here #36171
It's not "fix", but removing/hiding is better option, than leave it non working for 4 years! (#17759)

In developer branch, it's fixed already.

If we update any customer to 8.1.5, they are complaining about this "not working", so, when we hide this, customer will not reporting problem. Not best option, but better than leave this bug there X more years I think.......

@Lathanao
Copy link
Contributor

Really glad to discover that feature, thanks @ShaiMagal for that.
Btw, this feature look to work perfectly for me on PS 8.1.5:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BO Category: Back Office Bug Type: Bug Email theme Label: Which BO under menu is concerned NMI Status: issue needs more information Order statuses Label: Which BO under menu is concerned Waiting for PM Status: action required, waiting for product feedback
Projects
None yet
Development

No branches or pull requests

5 participants