Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excel Add-in online - function wizard function arguments broken #4419

Open
stefandrissen opened this issue May 1, 2024 · 4 comments
Open
Assignees
Labels
Area: custom functions Issue related to the Excel custom functions feature Area: Excel Issue related to Excel add-ins Needs: attention 👋 Waiting on Microsoft to provide feedback Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs

Comments

@stefandrissen
Copy link

stefandrissen commented May 1, 2024

I have just started trying to create my own Excel Add-in with custom functions.

When using local Excel on Windows 10, the functions work fine.
When using Excel Online, the function wizard is broken and only shows the first argument twice (with a sequence number).

Can be reproduced by uploading the sample manifest.xml as referenced by https://learn.microsoft.com/en-us/office/dev/add-ins/excel/custom-functions-overview with function GETKEYVALUEFORKEYCF which contains one key parameter:

https://github.com/OfficeDev/Office-Add-in-samples/blob/15b0646aa3eed1097071fe8fc44426e949a20f73/Samples/excel-shared-runtime-global-state/src/functions/functions.json#L7-L13

But is shown as:

image

The manifest.xml generated by Yeoman is also odd in that the function URLs have an additional /public folder:

      <bt:Urls>
        <bt:Url id="Functions.Script.Url" DefaultValue="http://localhost:3000/public/functions.js"/>
        <bt:Url id="Functions.Metadata.Url" DefaultValue="http://localhost:3000/public/functions.json"/>
        <bt:Url id="GetStarted.LearnMoreUrl" DefaultValue="http://go.microsoft.com/fwlink/?LinkId=276812"/>
        <bt:Url id="Taskpane.Url" DefaultValue="http://localhost:3000/taskpane.html"/>
      </bt:Urls>

Somehow this works fine when run on a local Excel installation, but fails when using the dist package (404 on public/functions.json) - the custom functions do not show. Removing public from the urls above does not result in the functions being listed, copying the functions.json to the public folder does.

@akrantz
Copy link

akrantz commented May 1, 2024

With shared runtime, there should be no need to have these url get files from /public. When dev server is running, it should serve these files up from what is generated in memory -- they won't be on disk -- so go to https://localhost:3000/functions.json (or .html or .js) in the browser and see if they are served up there.

@davidchesnut Could you please look into this?

@davidchesnut davidchesnut self-assigned this May 1, 2024
@davidchesnut davidchesnut added the Needs: attention 👋 Waiting on Microsoft to provide feedback label May 1, 2024
@davidchesnut
Copy link
Member

Hi @stefandrissen, thanks for reporting this issue. I can repro this with a new yo office project, so looks like a product bug. I'll move this to the office-js repo where we track product bugs.
Thanks!

@davidchesnut davidchesnut transferred this issue from OfficeDev/Office-Add-in-samples May 2, 2024
@davidchesnut
Copy link
Member

@adrianwu8516 this looks like a bug, can you please take a look? Thanks!

@davidchesnut davidchesnut added Area: Excel Issue related to Excel add-ins Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs Area: custom functions Issue related to the Excel custom functions feature labels May 2, 2024
@stefandrissen
Copy link
Author

stefandrissen commented May 8, 2024

The broken dialog seems to be the same issue as #3916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: custom functions Issue related to the Excel custom functions feature Area: Excel Issue related to Excel add-ins Needs: attention 👋 Waiting on Microsoft to provide feedback Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs
Projects
None yet
Development

No branches or pull requests

4 participants