Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize how the associate method is used. #4568

Open
Rick-Kirkham opened this issue May 14, 2024 · 0 comments
Open

Standardize how the associate method is used. #4568

Rick-Kirkham opened this issue May 14, 2024 · 0 comments
Assignees
Labels
Area: add-in UI Feedback on UI-related content (e.g., Fabric, dialogs, add-in commands, etc.) Needs: attention 👋 Waiting on Microsoft to provide feedback Type: doc request Request for new documentation or updates/enhancements to existing documentation

Comments

@Rick-Kirkham
Copy link
Contributor

Rick-Kirkham commented May 14, 2024

This section of the keyboard shortcuts article, Create a mapping of actions to their functions, tells users to pass an anonymous function as the 2nd parameter to the associate() method. This is a workable, but differs from other places in the platform docs where we use associate(). We should change these examples so that they create a named function and pass the name as the 2nd parameter. This is the way we do it for function commands as shown in: Create the code for the function command.

This will also have the advantage making it simpler to show how a function command can be linked to a keyboard shortcut and a ribbon button.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP label May 14, 2024
@Rick-Kirkham Rick-Kirkham added Area: add-in UI Feedback on UI-related content (e.g., Fabric, dialogs, add-in commands, etc.) Type: doc request Request for new documentation or updates/enhancements to existing documentation Needs: attention 👋 Waiting on Microsoft to provide feedback and removed Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: add-in UI Feedback on UI-related content (e.g., Fabric, dialogs, add-in commands, etc.) Needs: attention 👋 Waiting on Microsoft to provide feedback Type: doc request Request for new documentation or updates/enhancements to existing documentation
Projects
None yet
Development

No branches or pull requests

2 participants