Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (.NET) bot app error handling in template #10992

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix: (.NET) bot app error handling in template #10992

merged 1 commit into from
Mar 11, 2024

Conversation

qinezh
Copy link
Contributor

@qinezh qinezh commented Mar 5, 2024

Update .NET bot templates to send a message on error only when the activity is a message directed to it.

related PR: #10979
related issue: #10865
work item: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/27024570/

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.00%. Comparing base (4233980) to head (fe6e09d).
Report is 1 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #10992   +/-   ##
=======================================
  Coverage   87.00%   87.00%           
=======================================
  Files         451      451           
  Lines       26783    26783           
  Branches     5376     5376           
=======================================
  Hits        23303    23303           
  Misses       1758     1758           
  Partials     1722     1722           

@qinezh qinezh marked this pull request as ready for review March 6, 2024 01:52
@qinezh qinezh merged commit 169a2b3 into dev Mar 11, 2024
31 of 32 checks passed
@qinezh qinezh deleted the qinezh/boterror branch March 11, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants