Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bot app error handling in template and SDK #10979

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

qinezh
Copy link
Contributor

@qinezh qinezh commented Mar 4, 2024

Update bot templates and SDK to send a message on error only when the activity is a message directed to it.

This PR covers:

  • Update the error handling part in ConversationBot of TeamsFx SDK
  • Update the error handling part in Bot app JS/TS template if TeamsFx SDK is not used.
  • Update the SDK version in Bot app JS/TS template if Teams SDK is used.

The updates to .NET version of TeamsFx SDK and bot template will be covered in another separated PR, as it's not related to the 5.6.0 release.

work item: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/27024570/
related issue: #10865

@qinezh qinezh changed the base branch from dev to release/5.6.0 March 4, 2024 07:11
@qinezh qinezh force-pushed the qinezh/fix branch 2 times, most recently from 12b34a3 to 5668cbe Compare March 4, 2024 08:00
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.87%. Comparing base (08bb768) to head (62ed52a).
Report is 10 commits behind head on release/5.6.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/5.6.0   #10979      +/-   ##
=================================================
- Coverage          86.95%   86.87%   -0.08%     
=================================================
  Files                451      450       -1     
  Lines              26783    26598     -185     
  Branches            5386     5325      -61     
=================================================
- Hits               23288    23107     -181     
- Misses              1767     1768       +1     
+ Partials            1728     1723       -5     
Files Coverage Δ
...k/src/conversationWithCloudAdapter/conversation.ts 91.66% <100.00%> (+3.09%) ⬆️

... and 11 files with indirect coverage changes

@qinezh qinezh force-pushed the qinezh/fix branch 5 times, most recently from 19a045d to 41f5dfc Compare March 4, 2024 09:02
Copy link
Contributor

@wenytang-ms wenytang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve for the release part.

@MSFT-yiz MSFT-yiz merged commit 89f41f7 into release/5.6.0 Mar 5, 2024
33 of 34 checks passed
@MSFT-yiz MSFT-yiz deleted the qinezh/fix branch March 5, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants