-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bot app error handling in template and SDK #10979
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinezh
force-pushed
the
qinezh/fix
branch
2 times, most recently
from
March 4, 2024 08:00
12b34a3
to
5668cbe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/5.6.0 #10979 +/- ##
=================================================
- Coverage 86.95% 86.87% -0.08%
=================================================
Files 451 450 -1
Lines 26783 26598 -185
Branches 5386 5325 -61
=================================================
- Hits 23288 23107 -181
- Misses 1767 1768 +1
+ Partials 1728 1723 -5
|
qinezh
force-pushed
the
qinezh/fix
branch
5 times, most recently
from
March 4, 2024 09:02
19a045d
to
41f5dfc
Compare
qinezh
requested review from
kimizhu,
swatDong,
kuojianlu,
dooriya,
hund030,
yuqizhou77,
JerryYangKai,
eriolchan,
Siglud,
yukun-dong,
tecton,
blackchoey,
SLdragon,
wenytang-ms and
yiqing-zhao
as code owners
March 5, 2024 02:25
wenytang-ms
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve for the release part.
swatDong
approved these changes
Mar 5, 2024
kuojianlu
approved these changes
Mar 5, 2024
Siglud
approved these changes
Mar 5, 2024
hund030
approved these changes
Mar 5, 2024
yiqing-zhao
approved these changes
Mar 5, 2024
MSFT-yiz
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update bot templates and SDK to send a message on error only when the activity is a message directed to it.
This PR covers:
The updates to .NET version of TeamsFx SDK and bot template will be covered in another separated PR, as it's not related to the 5.6.0 release.
work item: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/27024570/
related issue: #10865