Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webjoin=true from VS Code templates launch.json so Teams launcher is used #11434

Open
therealjohn opened this issue Apr 22, 2024 · 2 comments
Assignees
Labels
investigating TA:PM PM investigation area

Comments

@therealjohn
Copy link
Contributor

To make it simpler for developers to run and debug in web OR desktop clients, the Teams launcher is the best solution right now. The launch.json in our templates currently avoids this by passing webjoin=true in the launch URL and it's unclear why.

i.e.
"url": "https://teams.microsoft.com/l/app/${{local:TEAMS_APP_ID}}?installAppPackage=true&webjoin=true&${account-hint}",

We could remove this so it would be:
"url": "https://teams.microsoft.com/l/app/${{local:TEAMS_APP_ID}}?installAppPackage=true&${account-hint}",

Then when you start debugging from VS Code, the default experience is to open the desktop client but you can also choose web if you prefer.

image

Copy link
Contributor

Thank you for contacting us! Any issue or feedback from you is quite important to us. We will do our best to fully respond to your issue as soon as possible. Sometimes additional investigations may be needed, we will usually get back to you within 2 days by adding comments to this issue. Please stay tuned.

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label Apr 22, 2024
@adashen adashen added investigating TA:PM PM investigation area labels Apr 23, 2024
@MuyangAmigo
Copy link
Collaborator

@therealjohn webjoin=true is added so we could enforce the account-hint to work. Otherwise if devs open desktop client and signed into a different account they will see App Not Found error and have no idea why.

@adashen adashen removed the needs attention This issue needs the attention of a contributor. label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigating TA:PM PM investigation area
Projects
None yet
Development

No branches or pull requests

3 participants