Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action required to prepare your app for cloud.microsoft by June 2024 #11224

Open
georgemichailou opened this issue Mar 28, 2024 · 7 comments
Open
Assignees
Labels
investigating needs more info Need user to provide more info TA:PM PM investigation area
Milestone

Comments

@georgemichailou
Copy link

Is your feature request related to a problem? Please describe.

In order to avoid any breaking changes to your app in the new (cloud.microsoft)domain, you will need to perform the following actions prior to June 2024:

  1. Upgrade to version 2.19 or above of the Teams JS library
  2. Retain the domains that your app’s CSP headers/ x-frame-options currently refer to
  3. Update your x-frame-options/CSP headers to allow for add:
    a. *.cloud.microsoft.com

Describe the solution you'd like
Can you inform us with the steps that need to follow to achieve this upgrade ?

Additional context
Developer Blog Post

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label Mar 28, 2024
@adashen adashen added investigating TA:PM PM investigation area labels Apr 1, 2024
@MuyangAmigo
Copy link
Collaborator

Hey @georgemichailou, Thank you for bringing this into our attention. We are formalizing a plan to update our samples and app templates to prepare for the domain change as well as a migration / upgrade support for any existing projects.

@MuyangAmigo MuyangAmigo added this to the Backlog milestone Apr 2, 2024
@georgemichailou
Copy link
Author

Thank you @MuyangAmigo !!!
Our production solution working with the following packages
image

Do we need to migrate to the latest version to prepare for this change or we can continue to use version 1.0.0 ?

@MuyangAmigo
Copy link
Collaborator

Hey @georgemichailou , we are evaluating if there's a need to update our SDKs, will keep you posted. But it's always good to use the latest stable version available.

@adashen adashen removed the needs attention This issue needs the attention of a contributor. label Apr 8, 2024
@therealjohn
Copy link
Contributor

We've updated the packages to bump the TeamsJS dependency and is available:
https://www.npmjs.com/package/@microsoft/teamsfx-react/v/3.1.2-alpha.2c983f96a.0
https://www.npmjs.com/package/@microsoft/teamsfx/v/2.3.2-alpha.2c983f96a.0
https://www.nuget.org/packages/Microsoft.TeamsFx/2.4.1-rc

@georgemichailou
Copy link
Author

@therealjohn i complete migration steps from v1.0.0 to 2.4.0 but i recieve the following error

image

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label May 10, 2024
@georgemichailou
Copy link
Author

Please update TeamsJsBlazorInterop.js in samples with inTeams function
in

@MuyangAmigo
Copy link
Collaborator

Please update TeamsJsBlazorInterop.js in samples with inTeams function in

Hey @georgemichailou, which sample are you referring to?

@adashen adashen added needs more info Need user to provide more info and removed needs attention This issue needs the attention of a contributor. labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigating needs more info Need user to provide more info TA:PM PM investigation area
Projects
None yet
Development

No branches or pull requests

6 participants