Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample Onboard Request] meetings-live-code-interview #1117

Open
Prithvi-MSFT opened this issue Dec 20, 2023 · 17 comments
Open

[Sample Onboard Request] meetings-live-code-interview #1117

Prithvi-MSFT opened this issue Dec 20, 2023 · 17 comments
Assignees
Labels
reviewed reviewed sample PR test passed sample pass test

Comments

@Prithvi-MSFT
Copy link

Owner:
Name - Prithvi / GitHub user name - Prithvi-MSFT

ID:
meetings-live-code-interview

Title:
meetings-live-code-interview

Description:
This sample demos live coding in a teams meeting stage using live share SDK. The tab is loaded as side panel which contains various coding questions.

Tags:
"JS", "Live Share SDK"

Time:
5 mins to run

Configuration:
Ready

Thumbnail:
https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/main/samples/meetings-live-code-interview/nodejs/assets/thumbnail.png

(Optional) Demo GIF:
https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/main/samples/meetings-live-code-interview/nodejs/assets/sampleDemo.gif

(Source code in this Repo) Source Code PR:
Code in another PR

(Source code NOT in this Repo) Sample URL:
https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/meetings-live-code-interview/nodejs

(Optional) Minimum Teams Toolkit Version:
Teams Toolkit version requirement to run the sample - minimum version

(Optional) Maximum Teams Toolkit Version:
Teams Toolkit version requirement to run the sample - maximum version

@JerryYangKai
Copy link
Contributor

JerryYangKai commented Jan 10, 2024

Hi @Prithvi-MSFT, after a quick test, the sample doesn't work in my local machine.
Repro step, download the app, using Teams ToolKit, press F5, in the pop-up browser, click 'install the app'.
Screen shot, in the meeting, cannot add the app, the config page is failed
image

I also raise this as an issue in the origin repository.
OfficeDev/Microsoft-Teams-Samples#1105

@prithvi7410
Copy link

@JerryYangKai - Thanks for reporting the issue. Will check on the sample issue

@Prithvi-MSFT
Copy link
Author

Hi @JerryYangKai - The issue is fixed and we have pushed the changes. Could you please verify once
OfficeDev/Microsoft-Teams-Samples#1109

@JerryYangKai
Copy link
Contributor

JerryYangKai commented Jan 12, 2024

Hi @Prithvi-MSFT, thanks for your quick reply.
I afraid I cannot run it in my local environment, I pull the latest changes then when I press F5, the frontend and backend terminal won't work, it will auto close after a few second. The screenshot is in the following:
image
image

Teams toolkit version 5.4.0
Node version
image

@JerryYangKai JerryYangKai added testing testing sample by following README test passed sample pass test and removed testing testing sample by following README labels Jan 15, 2024
@JerryYangKai
Copy link
Contributor

@summzhan Sample test passed, please help review the doc part,

@summzhan summzhan added the reviewed reviewed sample PR label Jan 17, 2024
@summzhan
Copy link
Contributor

README looks good to me.

@tecton
Copy link
Contributor

tecton commented Jan 18, 2024

Onboarding PR: #1128

@Prithvi-MSFT
Copy link
Author

@tecton - By when will it be available in samples list ?

@tecton
Copy link
Contributor

tecton commented Jan 30, 2024

@tecton - By when will it be available in samples list ?

Hi @Prithvi-MSFT, the sample is available in daily build version now. And it's expected to be released in next TTK prerelease version (next month).

@JerryYangKai
Copy link
Contributor

Hello @Prithvi-MSFT !
The preview version of teams toolkit has been released, after testing part of sample readme cannot render in VS Code, I created an issue and you can check it.
OfficeDev/Microsoft-Teams-Samples#1202

@summzhan
Copy link
Contributor

@JerryYangKai @Prithvi-MSFT , What's the status of this sample? it's seems stucked by weeks.

@Prithvi-MSFT
Copy link
Author

@JerryYangKai - Could you please guide me on the repro steps so I can create and test the issue ?

@JerryYangKai
Copy link
Contributor

@JerryYangKai - Could you please guide me on the repro steps so I can create and test the issue?

You can check the issue I created above, it is about the readme rendering, not the code running issue.

@Prithvi-MSFT
Copy link
Author

@JerryYangKai - In issue its mentioned its in internal preview. Could you please guide how can I test this ? As the readme seem to look correct in repository

@JerryYangKai
Copy link
Contributor

JerryYangKai commented Apr 13, 2024

@JerryYangKai - In issue its mentioned its in internal preview. Could you please guide how can I test this ? As the readme seem to look correct in repository

Now this version is released as preview version and can be repro.
Step 1 switch teams toolkit to pre release 5.7.X
image

Step 2 find the sample in sample gallery
image
image

Step 3 click the sample to see the readme, and the issue will come out
image
image

@Prithvi-MSFT
Copy link
Author

Prithvi-MSFT commented Apr 22, 2024

Hi @JerryYangKai ,
I followed the steps mentioned and installed the latest pre-released version of teams toolkit and the images were loading correctly for me.
image

@JerryYangKai
Copy link
Contributor

JerryYangKai commented Apr 23, 2024

Hi @JerryYangKai , I followed the steps mentioned and installed the latest pre-released version of teams toolkit and the images were loading correctly for me. image

Great!
This is the issue 2 I mentioned, how about the issue 1?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed sample PR test passed sample pass test
Projects
None yet
Development

No branches or pull requests

5 participants