Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[low priority] "Open in Composer" #23

Open
psychobunny opened this issue Feb 23, 2016 · 3 comments
Open

[low priority] "Open in Composer" #23

psychobunny opened this issue Feb 23, 2016 · 3 comments

Comments

@psychobunny
Copy link
Contributor

Original: NodeBB/NodeBB#3450

Seems like it would take quite a bit of an overhaul, hence the low priority tag

@pitaj
Copy link
Contributor

pitaj commented Aug 4, 2016

I'll take a look at it when I go back over the composer to hopefully simplify the codebase and convert most of the view logic to CSS. I may just end up doing a complete rewrite, who knows.

@julianlam
Copy link
Member

I may just end up doing a complete rewrite, who knows.

That's ambitious, if I do say so myself 😄 Not that I don't have faith, just that it may be a bit larger of a task than you imagine, simply because of the number of integrations.

As it stands now, a composer session is tied to some id, whether it be a tid or cid. Divorcing it from that could be done.

@pitaj
Copy link
Contributor

pitaj commented Aug 10, 2016

Well I did rewrite nodebb-plugin-calendar for the third time, and the composer isn't quite as complex. Plus, a lot of the view logic can be replaced with CSS, which makes everything a lot easier.

May need to use a bit of absolute positioning or calc. Would love to use flexbox, but unfortunately, IE is a thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants