Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create save command #10

Open
daniel-thom opened this issue Apr 12, 2024 · 0 comments · May be fixed by #23
Open

Create save command #10

daniel-thom opened this issue Apr 12, 2024 · 0 comments · May be fixed by #23
Assignees
@pesap
Labels
enhancement New feature or request

Comments

@daniel-thom
Copy link
Collaborator

The existing System.to_json method is fine. We are really dumping data to more than just JSON, though. We write time series data to SQLite and Arrow files. It would be good to have a System.save("my_directory") that creates a new directory and saves all files in it. The user could then easily create an achive (.zip/.tar) and share it. We could also consider making the archive file automatic and support deserializing from it.
@pesap pesap removed the [] label Apr 15, 2024
@pesap pesap self-assigned this May 1, 2024
@pesap pesap added the enhancement New feature or request label May 1, 2024
pesap added a commit that referenced this issue May 1, 2024
@pesap
feat(system): Added new method to save the system to a given folder.
d2e52c8 
List of changes:
- Created a new method `.save` that saves all the content of the system
  (.json + time series) to a desired folder,
- Save method can archive the folder to enable easy sharing of the
  system,
- Added testing to validate that save in fact creates the folder and
  that when we zip it we delete that folder.

Closes #10
@pesap pesap linked a pull request May 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pesap pesap

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(system): Added new method to save the system to a given folder. NREL/infrasys
2 participants
@pesap @daniel-thom