Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: TurbineInterface not covered in tests and examples #901

Open
misi9170 opened this issue May 6, 2024 · 1 comment
Open

Bug report: TurbineInterface not covered in tests and examples #901

misi9170 opened this issue May 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@misi9170
Copy link
Collaborator

misi9170 commented May 6, 2024

In merging #888, the deploy-book action failed because I had forgotten to update some function calls in the TurbineInterface object on on floris/turbine_library/turbine_previewer.py. I've now patched this (I think) in #900

Looking into this more, the reason that I missed these is that TurbineInterface is not tested, and also not used in any of the examples.

I would suggest that we consider either:

  1. Adding a test for the TurbineInterface or
  2. Deprecating TurbineInterface and just going through the FlorisModel in the documentation (full deprecation would need to wait until a later major release)
@paulf81
Copy link
Collaborator

paulf81 commented May 6, 2024

Based on this issue patched by #900 and the fact that it is only in documentation, it does seem reasonable to deprecate the functionality into FlorisModel, which will be more easily tracked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants