Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow user to change turbine model dynamically #724

Open
misi9170 opened this issue Oct 25, 2023 · 1 comment
Open

Feature request: Allow user to change turbine model dynamically #724

misi9170 opened this issue Oct 25, 2023 · 1 comment
Assignees
Labels
enhancement An improvement of an existing feature floris.tools
Milestone

Comments

@misi9170
Copy link
Collaborator

Current behavior

To change turbine models, and specifically, user-provided turbine yaml files that are not located in turbine_library/ but are instead !included in the FLORIS input yaml, users currently need to specify a second FLORIS input file. A good example of this is the FLORIS input files currently in examples/floating_inputs, where several FLORIS models exist that are identical except for the turbine model they call.

Desired behavior

To declutter the examples and provide users a simpler way of switching between turbine models, I'd like there to be an option of changing the turbine model of a FlorisInput object exported to a dictionary, so that a viable workflow would be:

fi_turb1 = FlorisInterface('example_floris_model_with_bang_included_turbine_model_1.yaml')
fi_dict = fi_turb1.floris.as_dict()
<code to change the bang-included turbine to turbine_model_2>
fi_turb2 = FlorisInterface(fi_dict)

As well as allowing us to clean up the examples, this also helps prevent growth in the number of needed examples and challenges/bugs associated with changing the examples. I could also imagine it becoming more important with turbines defined with multi CpCt tables.

@rafmudaf rafmudaf self-assigned this Nov 8, 2023
@rafmudaf rafmudaf added enhancement An improvement of an existing feature floris.tools labels Nov 8, 2023
@rafmudaf rafmudaf added this to the v4.0 milestone Nov 8, 2023
@misi9170
Copy link
Collaborator Author

#729 May help with this

@rafmudaf rafmudaf modified the milestones: v4.0, v4.1 Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature floris.tools
Projects
Status: Future Steps
Development

No branches or pull requests

2 participants