Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The initial deflection angle may have been calculated incorrectly. #617

Open
Hermse opened this issue Mar 31, 2023 · 2 comments
Open

The initial deflection angle may have been calculated incorrectly. #617

Hermse opened this issue Mar 31, 2023 · 2 comments
Assignees
Labels
bug Something isn't working floris.simulation
Milestone

Comments

@Hermse
Copy link

Hermse commented Mar 31, 2023

 # angle of deflection
        xi_init = cosd(yaw_i) * sind(yaw_i) * ct_i / 2.0

The initial deflection angle may have been calculated incorrectly.

I found the equation of the initial deflection in the paper: https://www.sciencedirect.com/science/article/pii/S0960148120300318

Proposed solution

 # angle of deflection
        xi_init = cosd(yaw_i) * cosd(yaw_i) * sind(yaw_i) * ct_i / 2.

Alternatives considered

I am not sure if it is a mistake or not, because the cosd(yaw_i) is close to 1 in fact.

@rafmudaf rafmudaf added the bug Something isn't working label Aug 2, 2023
@rafmudaf rafmudaf self-assigned this Aug 2, 2023
@rafmudaf rafmudaf added this to the v3.6 milestone Nov 7, 2023
@paulf81
Copy link
Collaborator

paulf81 commented Feb 20, 2024

Hi @Hermse , sorry this issue has been over-looked for so long. We will check more into this but at first glance believe this to be related that the ct value already includes a cos(yaw). @rafmudaf will follow-up with more details and we will try to clarify this in the future

@Hermse
Copy link
Author

Hermse commented Feb 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working floris.simulation
Projects
None yet
Development

No branches or pull requests

3 participants