Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine Cases Macro doesn't check simulation timesteps #1752

Open
brtietz opened this issue Apr 4, 2024 · 1 comment
Open

Combine Cases Macro doesn't check simulation timesteps #1752

brtietz opened this issue Apr 4, 2024 · 1 comment
Assignees
Labels

Comments

@brtietz
Copy link
Collaborator

brtietz commented Apr 4, 2024

Describe the bug

The combine cases macro will gleefully combine cases with different weather file timesteps, leading to odd phenomena like PV generating at night.

To Reproduce

Steps to reproduce the behavior:

  1. Set up a SAM case with two PV cases and a generic system
  2. Give one PV case an hourly weather file, and another case a subhourly file
  3. Set up a generic system to combine the cases, and run
  4. See PV generating at night!

Expected behavior

The combine cases macro should at least throw an error if a user tries to do this, or maybe if we have lots of time interpolate to a consistent timestep.

@brtietz brtietz added the bug label Apr 4, 2024
@brtietz brtietz added this to the SAM Fall 2024 Release milestone Apr 4, 2024
@janinefreeman
Copy link
Collaborator

Official vote to describe more of our bugs as "gleeful"! 😝

@brtietz brtietz self-assigned this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants