Simulation fails from Federal straight line depreciation check even when it is disabled

[cpaulgilman]

Describe the bug

The cashloan module generates a simulation error about Federal straight line depreciation not being positive even though it is not enabled:

Simulation error:

depr_fed_sl_years:fail(depr_fed_sl_years, positive): 0
Simulation cashloan failed :depr_fed_sl_years:fail(depr_fed_sl_years, positive): 0

Workaround

Workaround is to set Federal straight line depreciation to a positive number like 1, even when Federal straight line depreciation is not enabled.

To Reproduce

Steps to reproduce the behavior:

1. Create a default PVWatts / Commercial case.
2. On the Finanical Parameters page, set Federal depreciation to No depreciation.
3. Set Straight line to 0.
4. Click Simulate.
5. See error.

Expected behavior

If Federal or State depreciation is not set to the straight line option, SAM should not check the value of straight line depreciation.

Operating System and Version

• SAM 2023.12.17 r1 (also SAM 2023.12.17)
• Windows 11