Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add and change outputs (v3); bug fix (v2) #435

Merged
merged 20 commits into from Mar 17, 2023
Merged

add and change outputs (v3); bug fix (v2) #435

merged 20 commits into from Mar 17, 2023

Conversation

adfarth
Copy link
Collaborator

@adfarth adfarth commented Mar 9, 2023 •
edited

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • [N/A but one test modified ] Tests for the changes have been added (for bug fixes / features)
  • [Will update name mapping ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

(Bug fix, feature, docs update, ...)

Added
  • In job/ app (v3), added Financial year_one_om_costs_before_tax_bau, lifecycle_om_costs_after_tax_bau
Changed
  • In job/ app (v3), changed Financial breakeven_cost_of_emissions_reduction_per_tonnes_CO2 to breakeven_cost_of_emissions_reduction_per_tonne_CO2
  • In job/ app (v3), changed default ElectricLoad year to 2022 if user provides load data and 2017 if using CRBD
Fixed
  • In reo (v2), calculation of net_capital_costs_plus_om was previously missing addition sign for fuel charges. Corrected this equation.

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)

net_capital_costs_plus_om results will be different for v1 and v2 endpoints

Other information:

Depends on merging of NREL/REopt.jl#196

@adfarth adfarth linked an issue Mar 9, 2023 that may be closed by this pull request
change "year" defaults in API v3 #423
Open
@adfarth adfarth requested a review from rathod-b March 10, 2023 16:19
@adfarth adfarth marked this pull request as ready for review March 10, 2023 20:11
@adfarth adfarth changed the title Inputs outputs add and change outputs (v3); bug fix (v2) Mar 16, 2023
@Bill-Becker Bill-Becker mentioned this pull request Mar 17, 2023
Merged
@Bill-Becker Bill-Becker merged commit be5765f into develop Mar 17, 2023
@Bill-Becker Bill-Becker mentioned this pull request Mar 17, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bill-Becker Bill-Becker Bill-Becker left review comments

@rathod-b rathod-b Awaiting requested review from rathod-b

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
new API version with REopt.jl backend
Development

Successfully merging this pull request may close these issues.

change "year" defaults in API v3
2 participants
@adfarth @Bill-Becker