Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPWDesignCondition getters should return boost::optional #5132

Open
joseph-robertson opened this issue Mar 28, 2024 · 2 comments · May be fixed by #5134
Open

EPWDesignCondition getters should return boost::optional #5132

joseph-robertson opened this issue Mar 28, 2024 · 2 comments · May be fixed by #5134
Labels
Triage Issue needs to be assessed and labeled, further information on reported might be needed

Comments

@joseph-robertson
Copy link
Collaborator

Issue overview

Missing design condition (double?) fields in the header of the EPW file return a zero, and they shouldn't.

See #3086 for the original implementation.

Current Behavior

Expected Behavior

Steps to Reproduce

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version):
  • Version of OpenStudio (if using an intermediate build, include SHA):

Context
@joseph-robertson joseph-robertson added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Mar 28, 2024
@joseph-robertson joseph-robertson linked a pull request Apr 1, 2024 that will close this issue
Draft
19 tasks
@joseph-robertson
Copy link
Collaborator Author

Note that 2021 ASHRAE Handbook design conditions contain a new WSF element just before the cooling design conditions. Does this mean that the current version of the SDK's epw_file.designConditions doesn't support 2021 design condition headers?

See NREL/resstock#1137 for some context.

@shorowit
Copy link
Contributor

shorowit commented Apr 9, 2024

That's not part of the EPW spec, right? So it shouldn't be included in any EPW files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Triage Issue needs to be assessed and labeled, further information on reported might be needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle incomplete EPW design conditions header NREL/OpenStudio
2 participants
@shorowit @joseph-robertson