Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkflowJSON constantly calling setMeasureTypes (in the Ctor, in clone, in save, etc) #5083

Open
brianlball opened this issue Jan 25, 2024 · 0 comments
Assignees
Labels
component - logs and warnings Enhancement Request Triage Issue needs to be assessed and labeled, further information on reported might be needed

Comments

@brianlball
Copy link
Contributor

ValidateXML getting called a lot.

This is from slack convo from Julien:

WorkflowJSON.cpp
(https://github.com/NREL/OpenStudio/blob/1ce97f5651ff868500e4168aaa8e0a441559edce/src/utilities/filetypes/WorkflowJSON.cpp)
for (const auto& step : m_steps) {
if (step.optionalCastMeasureStep()) {
boost::optionalBCLMeasure bclMeasure = getBCLMeasure(step.castMeasureStep());
https://github.com/[NREL/OpenStudio](https://github.com/NREL/OpenStudio)|NREL/OpenStudioNREL/OpenStudio | Added by GitHub
10:18
that in turns loads the BCLMeasure, which validates the XML...

I do not get this to the out.osw “stdout” key with 3.7.0 on unix at least, but it’s in the run.log

that constant loading the BCLMeasure has been here for 8 years. What changed is that there used to be no XMLValidator happening.

@brianlball brianlball added Enhancement Request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - logs and warnings Enhancement Request Triage Issue needs to be assessed and labeled, further information on reported might be needed
Projects
None yet
Development

No branches or pull requests

3 participants