Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional design load detailed outputs #1632

Merged
merged 12 commits into from
Mar 15, 2024
Merged

Additional design load detailed outputs #1632

merged 12 commits into from
Mar 15, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Feb 27, 2024 •
edited

Pull Request Description

Closes #1631.

TODO:

  • AED curve
  • Disaggregate AED excursion
  • Disaggregate infiltration and ventilation
  • Unit tests
  • Allow user control over whether the new output file is created (and the file name?)
  • Handle JSON outputs

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the enhancement New feature or request label Feb 27, 2024
@shorowit shorowit self-assigned this Feb 27, 2024
@shorowit shorowit changed the base branch from master to room-by-room-sizing February 27, 2024 02:15
shorowit and others added 8 commits February 27, 2024 17:25
@shorowit
Merge branch 'room-by-room-sizing' of https://github.com/NREL/OpenStu…
79766f7 
…dio-HPXML into mj8_reporting

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/resources/hvac_sizing.rb
@shorowit
Merge branch 'room-by-room-sizing' of https://github.com/NREL/OpenStu…
415a1f6 
…dio-HPXML into mj8_reporting

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
@shorowit
Bugfix for walls.
bfd0dc9
@shorowit
Fix merge.
34d5991
Latest results.
4be082a
@shorowit
Merge branch 'room-by-room-sizing' of https://github.com/NREL/OpenStu…
ee1d073 
…dio-HPXML into mj8_reporting

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/resources/hvac_sizing.rb
#	workflow/tests/base_results/results_workflow_simulations2.csv
#	workflow/tests/base_results/results_workflow_simulations2_bills.csv
@shorowit
Add AED curve outputs.
5f55f1d
@shorowit
Disaggregate AED excursion from windows cooling sensible design load.
5161150
@shorowit shorowit added this to the 1.8.0 milestone Mar 15, 2024
@shorowit shorowit marked this pull request as ready for review March 15, 2024 22:23
@shorowit
Copy link
Contributor Author

Going to merge this in and continue development in #1578.

@shorowit shorowit merged commit 219c7f7 into room-by-room-sizing Mar 15, 2024
@shorowit shorowit deleted the mj8_reporting branch March 15, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Export additional detailed outputs related to design load
1 participant
@shorowit