Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update voltage in co-optimization #107

Open
mnblonsky opened this issue Feb 20, 2024 · 0 comments
Open

Update voltage in co-optimization #107

mnblonsky opened this issue Feb 20, 2024 · 0 comments
Assignees

Comments

@mnblonsky
Copy link
Collaborator

There is no way to update the house voltage when co-optimizing. (Co-optimization is iterating within a single time step, which can be done with Simulator.update_model.) Voltage can only be updated from the schedule_inputs, which only gets read in Simulator.update_inputs, not in Simulator.update_model.

There's also a question of whether "inputs" are significantly different from "controls". We can have both in the schedule, and it seems like both should be modified in co-optimization.

For now I think the plan is to remove the schedule_inputs argument from Simulator.update, have control_signal include all inputs and controls, and pass that to Simulator.update_model. This could involve a few other changes:

  • Rename controls to be consistent with schedule names.
  • Change control_signal from a 2-level dict to a 1-level dict (see Simulator.start_sub_update)
  • Use consistent names for schedule names and result names (e.g. "Ambient Dry Bulb" vs. "Temperature - Outdoor").
  • If we use consistent names, we can enumerate them. This may improve simulation speed when creating the schedule, parsing controls, and generating results.
@mnblonsky mnblonsky self-assigned this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant