Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using just the yaml package for handling !include funtionality #303

Open
bayc opened this issue Apr 1, 2024 · 0 comments
Open
Assignees

Comments

@bayc
Copy link
Collaborator

bayc commented Apr 1, 2024

Use yaml package for !include functionality

Currently, we depend on pyyaml-include package for enabling !include functionality in our input files. This feature would remove that dependency and adopt the same method that is used in the FLORIS repository for supporting the !include functionality.

Proposed solution

We would implement the same strategy as used in FLORIS, shown here: https://github.com/NREL/floris/blob/main/floris/utilities.py#L340

Alternatives considered

Keep it the way it is, but currently running into testing issues after pyyaml-include released a new major version.

@bayc bayc self-assigned this Apr 1, 2024
@bayc bayc linked a pull request Apr 12, 2024 that will close this issue
@bayc bayc removed a link to a pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant