Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSP modules need to update to resolve test failing on MacOS #154

Open
6 tasks
qualand opened this issue Aug 3, 2023 · 0 comments
Open
6 tasks

CSP modules need to update to resolve test failing on MacOS #154

qualand opened this issue Aug 3, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request refactor Associated with the refactor of HOPP

Comments

@qualand
Copy link
Collaborator

qualand commented Aug 3, 2023

CSP modules use an outdated version of SSC (SAM simulation core) which enables HOPP to "start and stop" the SAM simulation. This functionality is critical to how dispatch optimization interacts with the SAM performance model. Last year, the issue of platform inconsistent SSC results was addressed in the SSC repo. However, HOPP uses an older (stale) version of SSC because of the "start-stop" capability.

To fix this issue the following needs to happen (best case scenario):

  • The "start-stop" capability needs to be brought over from SSC daotk branch to the develop branch (https://github.com/mjwagner2/ssc/tree/daotk-develop )
  • PySAM needs to be released with the changes enabled
  • HOPP concentrating solar power modules need to be updated to interact with PySAM rather than PySSC (this would make them consistent with other technology modules in HOPP)

The quickest way to fix this is not to update the concentrating solar power modules in HOPP to use PySAM which would look like this:

Both of these solutions will require test values to change because SSC outputs have changed due to model improvements

  • Update Tests values based on new version of SSC
@qualand qualand added the refactor Associated with the refactor of HOPP label Aug 3, 2023
@qualand qualand self-assigned this Aug 3, 2023
@camirmas camirmas added the enhancement New feature or request label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Associated with the refactor of HOPP
Projects
None yet
Development

No branches or pull requests

2 participants