Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElectricLoadCenter:Storage:LiIonNMCBattery follow-up #9176

Open
5 tasks
shorowit opened this issue Nov 8, 2021 · 1 comment
Open
5 tasks

ElectricLoadCenter:Storage:LiIonNMCBattery follow-up #9176

shorowit opened this issue Nov 8, 2021 · 1 comment
Assignees
Labels
Defect Includes code to repair a defect in EnergyPlus

Comments

@shorowit
Copy link
Contributor

shorowit commented Nov 8, 2021

Issue overview

A running list of changes to consider for the new ElectricLoadCenter:Storage:LiIonNMCBattery object:

  • Hook up the DC to DC Charging Efficiency input. (It is currently unused.) Heat gain should be dumped into the battery's thermal zone.
  • Remove the default nominal cell voltage input? It's believed that this is only used by SAM to calculate the # of cells in series, but this is a direct input in EnergyPlus. (Double-check if there are any other unused inputs like this.)
  • Align the EnergyPlus default values with SAM? For example, SAM uses 3.6 as the cell voltage at end of nominal zone while EnergyPlus uses 3.342.
  • Update to the latest SAM SDK. The code has changed but it's not immediately known if it's anything substantive. Need to be wary of performance regressions (which has happened in the past).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

No branches or pull requests

3 participants