Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploaded images cause layout shifts #323

Open
rafaucau opened this issue Aug 7, 2022 · 1 comment
Open

Uploaded images cause layout shifts #323

rafaucau opened this issue Aug 7, 2022 · 1 comment
Labels

Comments

@rafaucau
Copy link
Contributor

rafaucau commented Aug 7, 2022

Bug Report

Current Behavior
Uploaded images cause the layout to shift which leads to the user seeing a different post than in the link.

Expected Behavior
The <img> should have width and height attributes. This way, the browser knows what size the image will be before it loads it which will prevent the layout from shifting.

Screenshots

A post containing an image. It jumps twice. After loading the image, it jumps to another post:

2022-08-07.12-39-34_Trim.mp4

Post near the post containing the image:

2022-08-07.12-40-05.mp4

Environment

  • Extension version: 1.2.3
@rafaucau rafaucau added the bug label Aug 7, 2022
@luceos
Copy link
Contributor

luceos commented Aug 7, 2022

This has been on my mind for a while. Perhaps we can use the crop measures or a sane default to measure height, then append those values to the default bbcode string..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants