Problem: Toponaming fails with index error

[sliptonic]

Is there an existing issue for this?

• I have searched the existing issues

Problem description

testfile attached. rename tntest.zip to tntest.fcstd

This is a straightforward test case. Open the sketch 'stretchme' and drag the right edge over.

tntest.zip

I see the following in the console

18:05:04  <PropertyLinks> PropertyLinks.cpp(453): tntest#Sketch002.Support missing element reference tntest#Pocket ;g11;SKT;:H1db,E;FAC;:H1db:4,F;:G0;XTR;:H1db:8,F;:H-1de,F.Face11
18:05:04  Sketch002: Shape index 11 out of bound 10
18:05:04  Sketch002: Shape index 11 out of bound 10

Full version info

OS: Linux Mint 21 (i3/i3)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37360 (Git)
Build type: Unknown
Branch: main
Hash: 2d2977abafd93c9ab97f9ad7beb25f5311c50b06
Python 3.10.12, Qt 5.15.3, Coin 4.0.0, Vtk 7.1.1, OCC 7.5.1
Locale: English/United States (en_US)
Installed mods: 
  * OpenDark 2023.12.17
  * fasteners 0.5.15
  * BillOfMaterials 0.0.7.2
  * sheetmetal 0.4.9
  * Ondsel-Lens 2024.1.15.01
  * FeedsAndSpeeds 0.5.0

Subproject(s) affected?

None

Anything else?

Compiled with toponaming enabled.

Code of Conduct

• I agree to follow this project's Code of Conduct

[maxwxyz]

@bgbsww FYI

[bgbsww]

So, after cleaning up other issues, we now seem to be matching the LS3 behavior. In both cases, if you stretch the edge of the sketch a pocket is based on to outside of the supporting face, it doesn't redraw, you get console errors, and if selected, the selection shows a history name:

LS3:
16:09:29 PropertyLinks.cpp(439): tntest#Sketch002.Support missing element reference tntest#Pocket ;#60;:H-1de,F.Face11
16:09:29 6.5e-08 Document.cpp(3424): Failed to recompute tntest#Sketch002: AttachEngine3D: subshape not found Pocket.Face11
16:09:29 Recompute failed!

Main:
16:07:55 PropertyLinks.cpp(453): tntest#Sketch002.Support missing element reference tntest#Pocket ;g11;SKT;:H1db,E;FAC;:H1db:4,F;:G0;XTR;:H1db:8,F;:H-1de,F.Face11
16:07:55 Sketch002: Shape index 11 out of bound 10
16:07:55 Sketch002: Shape index 11 out of bound 10

And in both cases, moving the pocket edge back in bounds works and seems to clean the maps correctly. This is after #14178 is in place.