Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect inputs from autofill #3969

Open
khvn26 opened this issue May 16, 2024 · 3 comments · May be fixed by #3980
Open

Protect inputs from autofill #3969

khvn26 opened this issue May 16, 2024 · 3 comments · May be fixed by #3980
Assignees
@kyle-ssg @novakzaballa

Comments

@khvn26
Copy link
Member

khvn26 commented May 16, 2024

Some of Flagsmith UI's inputs, like server-side environment key search box, is getting aggressively autofilled by Chromium-based browsers:

image

In case with this search box, this makes the server-side key list empty which is quite an inconvenience.

We need to prevent autocomplete on all relevant input fields.

Apparently, Chromium does not support autocomplete="off" attribute properly, as seen here: https://issues.chromium.org/issues/40093420

For my browser (Arc 124.0.6367.92) adding autocomplete="one-time-code" helped.
@Flagsmith Flagsmith deleted a comment from flagsmith bot May 17, 2024
@Flagsmith Flagsmith deleted a comment from flagsmith bot May 17, 2024
@Flagsmith Flagsmith deleted a comment from flagsmith bot May 17, 2024
@Flagsmith Flagsmith deleted a comment from flagsmith bot May 17, 2024
@Flagsmith Flagsmith deleted a comment from flagsmith bot May 17, 2024
@Flagsmith Flagsmith deleted a comment from flagsmith bot May 17, 2024
@flagsmith Flagsmith
Copy link

flagsmith bot commented May 17, 2024

The feature flag announcement was unlinked from the issue/PR

@novakzaballa novakzaballa linked a pull request May 17, 2024 that will close this issue
fix: Protect inputs from autofill #3980
Open
5 tasks
@novakzaballa novakzaballa linked a pull request May 20, 2024 that will close this issue
Open
5 tasks
@flagsmith Flagsmith
Copy link

flagsmith bot commented May 21, 2024

Flagsmith feature linked: 14
Default Values:

Environment Enabled Value Last Updated (UTC)
Production ❌ Disabled 2024-04-23 03:14:57
Development ❌ Disabled 2024-04-23 03:14:57
feature version ❌ Disabled 2024-04-23 03:14:57
Development ✅ Enabled 2024-05-07 19:27:29
Development ✅ Enabled 2024-05-10 18:55:34
Production ✅ Enabled value 2024-05-15 21:23:24
Production ❌ Disabled value 2 2024-05-15 21:24:56
Development ✅ Enabled 2024-05-21 00:59:41
Development ✅ Enabled 2024-05-21 01:01:39
Development ✅ Enabled 2024-05-21 01:03:05
Development ✅ Enabled 2024-05-21 01:03:42
Development ✅ Enabled 2024-05-21 01:05:00
Development ✅ Enabled 2024-05-21 01:05:37
Development ✅ Enabled 2024-05-21 01:06:00
Development ✅ Enabled 2024-05-21 01:07:21
Development ✅ Enabled 2024-05-21 01:15:33
Development ❌ Disabled test 2024-05-21 01:24:08
Development ✅ Enabled testvv2 2024-05-21 01:29:36
Development ✅ Enabled testvv2 2024-05-21 01:30:59

Segment power_users values:

Environment Enabled Value Last Updated (UTC)
Development ✅ Enabled test v2 segment 2024-05-21 01:31:04
Development ✅ Enabled testvv2 2024-05-21 01:32:17
Development ❌ Disabled test v2 segment 2 2024-05-21 01:32:20
Development ✅ Enabled testvv2 2024-05-21 01:35:00
Development ✅ Enabled test 3 2024-05-21 02:14:51
Development ✅ Enabled <xml>test3</xml> 2024-05-21 02:17:23
Development ✅ Enabled <xml>test3</xml> 2024-05-21 02:19:23

@flagsmith Flagsmith
Copy link

flagsmith bot commented May 21, 2024

The feature flag 14 was unlinked from the issue/PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyle-ssg kyle-ssg

@novakzaballa novakzaballa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Protect inputs from autofill Flagsmith/flagsmith
3 participants
@khvn26 @kyle-ssg @novakzaballa