Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make task description editing Android-friendly #30

Open
elimisteve opened this issue Feb 7, 2019 · 2 comments
Open

Make task description editing Android-friendly #30

elimisteve opened this issue Feb 7, 2019 · 2 comments

Comments

@elimisteve
Copy link
Member

@4xdk draft-js doesn't work on Android! 馃槮 I ran into this, sadly: http://engineering.mindlinksoft.com/why-draftjs-doesnt-work-on-android/

@4xdk @Moe-Shoman One of you guys want to do this? Let's just use https://github.com/cryptag/leapchat/blob/32bfca06ddc20c35b437d086f7b04c475256236b/src/components/chat/Message.js#L11-L57 but add the keyboard shortcuts that I added to the current editable descriptions version:

and
if (e.keyCode === 13 /* `enter` key */ && hasCommandModifier(e)) {
.

I should work on auth and backend stuff instead, to prep for Tuesday, but I can jump on this if you guys don't have time in the next 4 days or so!

@4xdk
Copy link
Collaborator

4xdk commented Feb 9, 2019

I'll have a look at this today.

@4xdk
Copy link
Collaborator

4xdk commented Feb 9, 2019

Did you mean to link to https://github.com/cryptag/leapchat/blob/32bfca06ddc20c35b437d086f7b04c475256236b/src/components/chat/MessageForm.js instead? Message.js contains only stuff related to displaying a message, nothing about editing there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants