Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated twitter logo #1709

Closed
wants to merge 6 commits into from
Closed

Updated twitter logo #1709

wants to merge 6 commits into from

Conversation

vinfinity7
Copy link
Contributor

@vinfinity7 vinfinity7 commented Oct 17, 2023 •
edited

Updated twitter logo form https://cdn-icons-png.flaticon.com/512/733/733579.png to https://vectorseek.com/wp-content/uploads/2023/07/Twitter-X-New-Logo-Vector-2.png at two instances , pin me more instances of twitter logo
Fixes #1696

What

🤖 Generated by Copilot at 8568fc6

Updated the Twitter icons for the integration card and the Eagle Eye platform to use a higher-resolution and more consistent icon from icons8.com. This improves the visual appearance and quality of the frontend.
​

🤖 Generated by Copilot at 8568fc6

Twitter icon changed
From icons8.com site
A crisp autumn leaf

Why

How

🤖 Generated by Copilot at 8568fc6

  • Update Twitter icon for integration card and Eagle Eye platform (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@vinfinity7
Copy link
Contributor Author

@mattinannt you might wanna look into this

joanagmaia
joanagmaia requested changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! In twitter's integration configuration you are updating this to an icon, not an image, so it's' not rendering properly. Can you provide a valid image url or add it to the project directory?
Same thing for eagle eye logo.
There's also another place that will need update. You'll also need to add svg support in crowd-icons for twitter logo. That's still with the old one.

@vinfinity7
Copy link
Contributor Author

Hey! In twitter's integration configuration you are updating this to an icon, not an image, so it's' not rendering properly. Can you provide a valid image url or add it to the project directory? Same thing for eagle eye logo. There's also another place that will need update. You'll also need to add svg support in crowd-icons for twitter logo. That's still with the old one.

Ive updated the icon to a png file @joanagmaia

@vinfinity7 vinfinity7 closed this Oct 29, 2023
@vinfinity7 vinfinity7 deleted the typo branch October 29, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanagmaia joanagmaia joanagmaia requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the Twitter logo to X
2 participants
@vinfinity7 @joanagmaia