Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of Top activities by type widget in dashboard #1589

Open
joanagmaia opened this issue Sep 30, 2023 · 4 comments
Open

Improve display of Top activities by type widget in dashboard #1589

joanagmaia opened this issue Sep 30, 2023 · 4 comments
Assignees
Labels
Hacktoberfest Created by Linear-GitHub Sync help wanted 🙏 help from the community is highly appreciated Improvement Created by Linear-GitHub Sync Reports and analytics Created by Linear-GitHub Sync

Comments

@joanagmaia
Copy link
Contributor

Steps to achieve this:

  1. Only show a preview of the Top 5 activities. If number of activities > 5, show "View all" button to display the remaining ones
Screenshot 2023-09-12 at 14 30 02
  1. If "View all" is clicked, open a Drawer component with a list of the first 20 activities. Below the title of the header, display the applied filters (time, platform, and channel (channel should only be added when this task C-2249 is completed))
Screenshot 2023-09-12 at 14 32 04 Screenshot 2023-09-12 at 14 32 10
  1. If list of activities in drawer has > 20 activities, display a "Load more" button. If button is clicked, we should add 20 more results to it, until all activities are loaded.

Technical specs

  • dashboard.cube.js should be updated in activityTypes method payload to Cube. You should add limit, offset to the payload to handle pagination. You should also add total: true, to that response retrieves total of results. This will be useful to add logic to check if View all button should be added or not. https://cube.dev/docs/guides/recipes/queries/pagination
  • dashboard-activity-types.vue should be updated with the new "View all" button according to the pagination
  • For the implementation of the drawer, use app-drawer component
@joanagmaia joanagmaia added Improvement Created by Linear-GitHub Sync help wanted 🙏 help from the community is highly appreciated Reports and analytics Created by Linear-GitHub Sync Hacktoberfest Created by Linear-GitHub Sync labels Sep 30, 2023
@ShatilKhan
Copy link

Please assign this issue to me. I've done frontend contributions before

@joanagmaia
Copy link
Contributor Author

Please assign this issue to me. I've done frontend contributions before

Sure 😄

@ShatilKhan
Copy link

Thanks @joanagmaia
Apologies for my delay, can you give some guidance on which files to work on?

@joanagmaia
Copy link
Contributor Author

Thanks @joanagmaia Apologies for my delay, can you give some guidance on which files to work on?

Hey @ShatilKhan , did you check the technical specs on the issue description? It mentions which files to update. If you need any help setting the app locally let me know as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Created by Linear-GitHub Sync help wanted 🙏 help from the community is highly appreciated Improvement Created by Linear-GitHub Sync Reports and analytics Created by Linear-GitHub Sync
Projects
Status: No status
Development

No branches or pull requests

2 participants