Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an image seems like it doesn't take #122

Open
dreeves opened this issue Nov 1, 2021 · 2 comments
Open

Adding an image seems like it doesn't take #122

dreeves opened this issue Nov 1, 2021 · 2 comments

Comments

@dreeves
Copy link

dreeves commented Nov 1, 2021

Replicata

  1. Be on Chrome on macOS or probably any browser.
  2. Find or create a proposal in some list
  3. Click "Edit" to edit it
  4. Click "Choose File" under "Pic" to add an image for the proposal
  5. Click "Update"

Expectata

That I'm back on the proposal page looking at my shiny new image.

Resultata

I'm back on the proposal page and I still see the old image and I think it didn't work.

PS: I just followed these steps again carefully to make sure it's all true and it is but then after some number of seconds the image did refresh itself! So that's a downgrade in severity. Not sure how consistent that delay is.

PPS: Ok, I wasn't crazy, sometimes it takes like a minute or more.

@tkriplean
Copy link
Member

tkriplean commented Nov 2, 2021

Thanks Daniel! The delay is from waiting for the image to be processed and uploaded to s3/cloudfront. Meanwhile, the client polls the server until a url is available. The same issue happens when uploading a user avatar, but I have a bit of a hack to make that a little bit better, but I didn't implement the hack because this proposal-pic option is so rarely used. It is nice to have the issue logged though.

@dreeves
Copy link
Author

dreeves commented Nov 2, 2021

Just having it say "loading" or something until it's ready would be completely fine from a user viewpoint. It only threw me because I thought it had silently failed (and didn't realize till I was replicating it that it does eventually refresh itself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants