Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Set/Map delete on iteration #60

Open
Bnaya opened this issue Dec 29, 2019 · 2 comments
Open

Fix Set/Map delete on iteration #60

Bnaya opened this issue Dec 29, 2019 · 2 comments

Comments

@Bnaya
Copy link
Owner

Bnaya commented Dec 29, 2019

Currently deleting the current iterated item on Map/Set will lead to skip the next item.

To fix that we need:

  • Allocate iterator inside the ArrayBuffer
  • Update the iterator on delete
  • add deallocation of that iterator on iteration end, manual, and on finalizationGroup
    For now its a known limitation
@Bnaya Bnaya changed the title Fix Set/Map iteration Fix Set/Map delete on iteration Jan 5, 2020
@Bnaya Bnaya added this to the Post 1.0 milestone Feb 8, 2020
@aweiu
Copy link

aweiu commented Apr 2, 2024

Anything update on it?🙏

@Bnaya
Copy link
Owner Author

Bnaya commented Apr 3, 2024

Anything update on it?🙏

It's a hard-fix, maybe you can work with a append only strategy, and increment a counter to the latest message that wasn't red yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants