Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Optimizations] In hashmap creation don't check if key already exists in bucket #117

Open
Bnaya opened this issue Jun 20, 2020 · 0 comments
Open

[Optimizations] In hashmap creation don't check if key already exists in bucket #117

Bnaya opened this issue Jun 20, 2020 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Bnaya
Copy link
Owner

Bnaya commented Jun 20, 2020 •
edited

When creating hashmap,
when check if keys already exists even thu it's guaranteed to be not, because we use hashMapInsertUpdateKeyIsPointerReturnNode and not dedicated function

https://github.com/Bnaya/objectbuffer/blob/develop/src/internal/hashmap/hashmap.ts#L89-L95

Also maybe avoid re-hash on creation if it comes to re balance.
@Bnaya Bnaya added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 20, 2020
@Bnaya Bnaya mentioned this issue Jun 20, 2020
Open
11 tasks
@abrl91 abrl91 removed their assignment Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bnaya @abrl91