Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unfollowed threads #5504

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: remove unfollowed threads #5504

wants to merge 2 commits into from

Conversation

SanjaySargam
Copy link
Contributor

Proposed changes

Threads updating immediately if unfollowed in Following Filter

Issue(s)

Fixes #5503

How to test or reproduce

  1. Go to RoomView
  2. Click on Threads
  3. Select display following filter
  4. Unfollow any one of the thread

Screenshots

WhatsApp.Video.2024-01-21.at.5.20.11.PM.mp4

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@GleidsonDaniel
Copy link
Contributor

Can you add an e2e test?

@SanjaySargam
Copy link
Contributor Author

Can you add an e2e test?

Please guide me on how I can add the e2e test, or are there any docs for this?

@GleidsonDaniel
Copy link
Contributor

GleidsonDaniel commented Jan 31, 2024 •
edited

Can you add an e2e test?

Please guide me on how I can add the e2e test, or are there any docs for this?

https://github.com/RocketChat/Rocket.Chat.ReactNative/tree/develop/e2e

If you have any doubts, just tell me.
In this case, you would just add a test to check whether the item really disappeared from the list.

@SanjaySargam
Copy link
Contributor Author

@GleidsonDaniel I read the documentation but didn't understand how to write tests. Is there any merged PR who wrote the test in it, so that I can refer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GleidsonDaniel GleidsonDaniel GleidsonDaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unfollowing in the Following Filter doesn't instantly update thread changes.
2 participants
@SanjaySargam @GleidsonDaniel