Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message details not shown in push notifications anymore #5496

Open
paulchen opened this issue Jan 18, 2024 · 51 comments · May be fixed by #5596
Open

Message details not shown in push notifications anymore #5496

paulchen opened this issue Jan 18, 2024 · 51 comments · May be fixed by #5596

Comments

@paulchen
Copy link

Description:

The notifications on my Android phone do not show any message details anymore, just the text "You have a new message", despite the server being configured to deliver message details.

Environment Information:

  • Rocket.Chat Server Version: 3.5.3
  • Rocket.Chat App Version: 4.45.0.55377
  • Device Name: ELE-L29 (Huawei P30)
  • OS Version: EMUI 12.0.0 (Android 11)

Steps to reproduce:

  1. Configure the server like this (Workspace -> Settings -> Push -> Privacy):

Clipboard - January 18, 2024 23_19

  1. Wait for a push notification being shown on your mobile phone.

Expected behavior:

The message is shown on the push notification, including its details.

Actual behavior:

The push notification does not contain any message details:

Screenshot_20240118_231842

Additional context:

This issue is quite new, it must have been introduced in one of the most recent versions of the Rocket.Chat server or the app.

@preeesha
Copy link

Hey @paulchen, thanks for pointing out the issue

@GleidsonDaniel, can I work on this issue? My approach will be to first verify whether the issue belongs to this repository or the primary mono repo of Rocket.Chat. If this issue is in the app only then I will dive into the notification pushing process and update you with results.

Thanks for your time and consideration
Prisha Gupta

@GleidsonDaniel
Copy link
Contributor

Hey @paulchen, thanks for pointing out the issue

@GleidsonDaniel, can I work on this issue? My approach will be to first verify whether the issue belongs to this repository or the primary mono repo of Rocket.Chat. If this issue is in the app only then I will dive into the notification pushing process and update you with results.

Thanks for your time and consideration Prisha Gupta

I don't recommend working on this issue.
The notification flow is a very complex flow, and we are already working on this issue internally.

@GleidsonDaniel
Copy link
Contributor

Hey @paulchen, can you find out if this happened after updating the app or the server?
Because testing here on some servers, I realized that the problem is intermittent, showing that the problem is not really in the mobile app, because if it were on the mobile it wouldn't work any of the time.
On a private server (with very few users) with these same settings it worked 100% of the time.

I'm waiting for more information.

@paulchen
Copy link
Author

Hey @paulchen, can you find out if this happened after updating the app or the server?

I noticed the problem on Jan 19 in the evening. The app on my mobile phone was last updated on Jan 16.

There was no update to the server on Jan 19, but I restarted the instance twice earlier that day (due to updating MongoDB from 6.0.12 to 6.0.13 and later Docker from 24.0.7 to 25.0.0). However, all the messages that triggered the problem were sent at a later time.

Because testing here on some servers, I realized that the problem is intermittent, showing that the problem is not really in the mobile app, because if it were on the mobile it wouldn't work any of the time.

Since I reported the issue, I have received some notifications that worked as expected while others didn't.

On a private server (with very few users) with these same settings it worked 100% of the time.

My instance is a small instance on the Starter plan with 18 registered users.

@loopway
Copy link

loopway commented Jan 25, 2024

similar situation here: updated rocket.chat server (starter) on January 11 from 6.4.0 to 6.5.2 (and mongodb from 4.4.21 to 6.0.12). ios app got updated on January 17 to 4.45.0. all but one (!) push notifications did not show details.

@GleidsonDaniel
Copy link
Contributor

similar situation here: updated rocket.chat server (starter) on January 11 from 6.4.0 to 6.5.2 (and mongodb from 4.4.21 to 6.0.12). ios app got updated on January 17 to 4.45.0. all but one (!) push notifications did not show details.

Are you having this error on iOS too?
Or is your device Android?

@loopway

This comment was marked as resolved.

@Vaxter
Copy link

Vaxter commented Feb 15, 2024

similar situation here: updated rocket.chat server (starter) on January 11 from 6.4.0 to 6.5.2 (and mongodb from 4.4.21 to 6.0.12). ios app got updated on January 17 to 4.45.0. all but one (!) push notifications did not show details.

Are you having this error on iOS too? Or is your device Android?

I do have the same issue on iOS, both on iPad and iPhone.
For me this has started happening once I have signed up for this free preium thing.
It’s A self hosted on site instance.

@matbgn
Copy link

matbgn commented Feb 16, 2024

Same problem here. This started from the day we bumped Rocket.Chat Server from version 6.4.X to 6.5.X

@0ki
Copy link

0ki commented Feb 16, 2024

Same. After upgrade to 6.5 notification text disappeared. Any way to debug?

@diegolmello
Copy link
Member

diegolmello commented Feb 16, 2024

FYI we've been investigating this issue.

@matheusbsilva137
Copy link
Contributor

@paulchen are you also using the Starter plan on your workspace? Or is it running a Pro/Enterprise license?
You can check this in Workspace > Administration > Subscription.

@paulchen
Copy link
Author

@paulchen are you also using the Starter plan on your workspace? Or is it running a Pro/Enterprise license? You can check this in Workspace > Administration > Subscription.

Starter plan.

However, in the recent days I have not encountered the problem.

@matbgn
Copy link

matbgn commented Feb 20, 2024

Error still happening on iOS for information

@0ki
Copy link

0ki commented Feb 27, 2024

Just started working today randomly. No update to app, nor the server.

@Vaxter
Copy link

Vaxter commented Feb 27, 2024

Same for me a couple of days ago, but it’s Really random.
Some notifications have preview, and some don’t.

@diegolmello diegolmello self-assigned this Feb 27, 2024
@diegolmello
Copy link
Member

I have a possible fix on #5596
But I need help testing from all of you, @paulchen @loopway @Vaxter @matbgn @0ki .

Here's the link to TestFlight https://testflight.apple.com/join/3gcYeoMr
Build version should be 4.47.0.58428.

Thanks!
Let me know if you have any questions.

@paulchen
Copy link
Author

Here's the link to TestFlight https://testflight.apple.com/join/3gcYeoMr Build version should be 4.47.0.58428.

Unfortunately, I'm unable to use TestFlight.

  • Device Name: ELE-L29 (Huawei P30)
  • OS Version: EMUI 12.0.0 (Android 11)

@diegolmello
Copy link
Member

@paulchen I wasn't able to reproduce the issue on Android at all.
Let me know if it happens again.

@matbgn
Copy link

matbgn commented Feb 27, 2024

Again it happened today. I'm personally on Android, I have a colleague who is on iOS but won't be able to help with TestFlight

@Vaxter
Copy link

Vaxter commented Feb 27, 2024

I have a possible fix on #5596

But I need help testing from all of you, @paulchen @loopway @Vaxter @matbgn @0ki .

Here's the link to TestFlight https://testflight.apple.com/join/3gcYeoMr

Build version should be 4.47.0.58428.

Thanks!

Let me know if you have any questions.

Installed on all of my devices.
I'll give it a run for a couple of days and let you know.

@0ki
Copy link

0ki commented Feb 27, 2024

I'd love to test, but the problem has fully disappeared on its own, so I'm afraid I might not be able to verify the fix atm.

@Vaxter
Copy link

Vaxter commented Feb 28, 2024

@paulchen Still happening. Now when phone is unlocked I sometimes can see the sender and content, and when locked still the same.
Notifications are set up to show everything even when locked.
Same on my iPad.

@diegolmello
Copy link
Member

diegolmello commented Feb 28, 2024

@Vaxter Thanks for the feedback.
It looks exactly what I described on known bugs there, but not only after boot #5596

I'll have to investigate deeper.
I'm going to let you all know once I have more info.

@diegolmello
Copy link
Member

@Vaxter Try this workaround, but might be tricky to do:

  • Install app from App Store
  • Restart device
  • Receive a push only after device is unlocked
  • App is going to reuse that same valid instance to fetch content

If you do it, let me know if it works forever (or until you restart).
That might be what happened to @0ki

@harryb303
Copy link

@diegolmello also been experiencing this issue since updating to 6.5 around the middle of January. Happens whether my iPhone is locked or unlocked. Updated to 6.6.1 today but problem persists. Installed the TestFlight build.

@harryb303
Copy link

@Vaxter Try this workaround, but might be tricky to do:

* Install app from App Store

* Restart device

* Receive a push only after device is unlocked

* App is going to reuse that same valid instance to fetch content

If you do it, let me know if it works forever (or until you restart). That might be what happened to @0ki

Just tried this, reinstalled the App Store build over the TestFlight build, restarted the phone, unlocked, waited for a push notification and it showed the message content, then locked the phone and received another notification with the message content. Will report back if the issue comes back.

@diegolmello
Copy link
Member

Btw there's nothing that proves 6.5 is related to this issue.
Our backend team took a look at this last week and couldn't find anything.

On iOS, it's related to how MMKV is handled by iOS when phone is locked (and other behaviors).
On Android, I still need to investigate.

If this issue is something that's impacting your use case negatively, you should turn off the setting until we have a fix (or try the workaround above).

@ulope
Copy link

ulope commented Feb 28, 2024

I've just updated (due to being forced, I've learned to never trust RC updates because something breaks every single damn time) from 6.4.2 to 6.6.1 and now notifications all of a sudden are missing content so I'd say it'd pretty clearly related to the server version.

@diegolmello
Copy link
Member

@ulope Did you have the setting enabled before the update or was it enabled for you afterwards?

@ulope
Copy link

ulope commented Feb 28, 2024

I can't really say. I definitely didn't change anything except updating.

@paulchen
Copy link
Author

@paulchen I wasn't able to reproduce the issue on Android at all. Let me know if it happens again.

@diegolmello The issue did not occur recently, neither for me nor for any of my users.

@diegolmello
Copy link
Member

6.5 moved some workspaces to the Starter plan, which means those workspaces now have access to almost all enterprise features.
Since Secure Push Notifications is enabled by default and it used to be a paid feature, now you're actually using it on Starter.

Let me know if it makes sense.

@matbgn

This comment was marked as abuse.

@harryb303
Copy link

Issue has returned this morning. Have not restarted the phone or touched the app or our server.

@0ki
Copy link

0ki commented Feb 29, 2024

Issue has magically returned this morning. No app updates, no server updates. What is this? Seems like a gateway issue?

@ulope
Copy link

ulope commented Feb 29, 2024

Still seeing this here as well. Users are starting to notice and complain :/

@diegolmello
Copy link
Member

#5496 (comment)

If this issue is something that's impacting your use case negatively, you should turn off the setting until we have a fix

Workspace -> Settings -> Push -> Privacy

image

@ulope
Copy link

ulope commented Feb 29, 2024

In our instance it's not possible to disable this setting.

The toggle is disabled:

@diegolmello
Copy link
Member

@ulope What plan are you on right now?

@ulope
Copy link

ulope commented Mar 2, 2024

@diegolmello no plan, community edition.

@matheusbsilva137
Copy link
Contributor

matheusbsilva137 commented Mar 4, 2024

@ulope have you been on Starter plan (or any other Premium plan) at some point recently and disabled it? Or have you always been on community?

@matbgn
Copy link

matbgn commented Mar 4, 2024

Is there a way to fully switchback to community?

@ulope
Copy link

ulope commented Mar 5, 2024

@matheusbsilva137 Yes the upgrade to 6.6.1 auto-enrolled us to the starter plan (which I did not at all appreciate btw, overbearing marketing dark patterns like this just suck, and probably are illegal in a good number of countries I might add).

@matbgn Yes, totally intuitively you have to click the "cancel subscription" at the bottom edge of the manage subscription screen.

@0ki
Copy link

0ki commented Mar 6, 2024

Notifications have randomly started working properly again this evening. No changes to client or server on our part.
About 1600-1700 UTC, I'd say.

Any ideas?

@0ki
Copy link

0ki commented Mar 6, 2024

What did change, is that I rebooted my phone. Hmmm.

@0ki
Copy link

0ki commented Mar 27, 2024

This started working randomly at one point and broke later that same day after I updated the Rocket Chat client on iOS. Hasn't been working since.

@svenseeberg
Copy link

svenseeberg commented Apr 10, 2024

This started working randomly at one point and broke later that same day after I updated the Rocket Chat client on iOS. Hasn't been working since.

The same for us. It seems that it works for some time after restarting the service but then breaks.

@diegolmello
Copy link
Member

I'm going to send a new TestFlight version in a few days. Just need to finish testing something else first. I'll be in touch.

@mdoesburg
Copy link

mdoesburg commented May 1, 2024

@diegolmello Any update on this? Not being to able to see message details/previews anymore (on iOS) is getting really frustrating. 😂

@0ki
Copy link

0ki commented May 13, 2024

An update from my side - still affected on iOs for the past month. Any plans on fixing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet