Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No border #190

Open
slavzilla opened this issue Jan 25, 2021 · 3 comments
Open

No border #190

slavzilla opened this issue Jan 25, 2021 · 3 comments

Comments

@slavzilla
Copy link

This is more a request than an issue. If you pass borderSize = 0 it actually is not 0 it is 1 pixel. This is an issue if you want to generalize a function let's say like this:

fun ImageView.loadCircularImage(uri: String?, width: Float){ val options = RequestOptions() .placeholder(android.R.color.transparent) Glide.with(context).setDefaultRequestOptions(options).load(uri) .apply(RequestOptions.bitmapTransform(CropCircleWithBorderTransformation(context.dp2px(width), Color.WHITE))) .into(this) }

If I want no border I would simply pass 0 to this function but It won't actually work because of this:
paint.setStrokeWidth(borderSize);
I could use CropCircleTransformation but it is deprecated.

@slavzilla
Copy link
Author

You can have a workaround for this particular case like this:
fun ImageView.loadCircularImage(uri: String?, width: Float){ val options = RequestOptions() .placeholder(android.R.color.transparent) Glide.with(context).setDefaultRequestOptions(options).load(uri) .apply { if (width > 0){ apply(RequestOptions.bitmapTransform(CropCircleWithBorderTransformation(context.dp2px(width), Color.WHITE))) } else { apply(RequestOptions.circleCropTransform()) } } .into(this) }
But this is not really a solution, right? 0 is still not 1.

@bryantmero
Copy link

@slavzilla , I have used:
fun ImageView.loadCircularImage(uri: String?, width: Float){ val options = RequestOptions() .placeholder(android.R.color.transparent) Glide.with(context).setDefaultRequestOptions(options).load(uri) .apply { if (width > 0){ apply(RequestOptions.bitmapTransform(CropCircleWithBorderTransformation(context.dp2px(width), Color.WHITE))) } else { apply(RequestOptions.circleCropTransform()) } } .into(this) }

But not getting expected result either

@slavzilla
Copy link
Author

@slavzilla , I have used: fun ImageView.loadCircularImage(uri: String?, width: Float){ val options = RequestOptions() .placeholder(android.R.color.transparent) Glide.with(context).setDefaultRequestOptions(options).load(uri) .apply { if (width > 0){ apply(RequestOptions.bitmapTransform(CropCircleWithBorderTransformation(context.dp2px(width), Color.WHITE))) } else { apply(RequestOptions.circleCropTransform()) } } .into(this) }

But not getting expected result either

Yeah man, I eventually gave up. Nobody replied for like two years...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants