Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website docs: Skins #Accessible Combinations bg-yellow, flex classes to parent. #685

Open
orionrush opened this issue Nov 23, 2020 · 0 comments

Comments

@orionrush
Copy link

Some of the color blocks are of different heights because the content is missing lines. Specifically, blocks that would have the bg-yellow class (which would equate to background-color:#FFFF00 ) are missing the descriptive

Also, I find it very odd that the blocks in the 'Accessible Combinations' have in-line color styles rather than actually using the tachyons classes to do the work, so not all of these combinations are available as advertised.

On the appearance front, to keep different content heights from breaking the flow or leaving gaps flex classes should be added to the parent ul.

from:
<ul class="cf list pl0 ml0">
to:
<ul class="list pl0 ml0 flex flex-wrap">

related:
#466
#139
#632
#193
tachyons-css/tachyons-css.github.io#193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant