-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: ambiguous outer attributes #125199
Comments
WG-prioritization assigning priority (Zulip discussion). My question here is how do we want to handle the changes in #124099. I don't see a mention of it being aware about breaking changes (PR was even rolled up). @rustbot label -I-prioritize +P-critical |
I looked into each regression. Most are caused by a dependency on rustrict (versions 0.3.13..0.5.14) which contains the following code (source): /// TODO: This is untested.
#[cfg(feature = "reset_censor")]
pub fn reset(&mut self, text: I) {
// ...
#[cfg(any(feature = "find_false_positives", feature = "trace"))]
self.total_matches = 0;
// ...
} I assume the author meant to apply the attribute to the whole assignment statement but here it only applies to the expression Besides rustrict there are three more problematic crates: thoughts_server, leptos_router, and varies. To summarize, in each case, an attribute is applied to the left-hand side of an assignment, which most likely does not match the authors' intention. This is exactly the kind of mistake that the error introduced in #124099 is meant to prevent. |
I'm unclear whether this requires nightly to trigger? This should probably be reverted and changed to a future compat warning. |
Issue was briefly mentioned today in the t-compiler triage meeting (on Zulip). Seems that given the timeframe leading to the next stable (2024-06-13, in 13 days), a revert would be more appropriate. |
Probably #124099 cc @davidtwco
The text was updated successfully, but these errors were encountered: